SUPPORT SEMI/ANTI JOIN syntax #723
Conversation
| match kw { | ||
| Keyword::LEFT => JoinOperator::LeftOuter, | ||
| Keyword::RIGHT => JoinOperator::RightOuter, | ||
| _ => unreachable!(), |
There was a problem hiding this comment.
@mingmwang for this and all the next unreachable!(). Even if this is really unreachable, please try to add an error here, or handle it in a different way. Being unsafe is not really good.
There was a problem hiding this comment.
I see the unreachable!() is used in other places in the code base. I just follow the same
code style.
There was a problem hiding this comment.
Since it can have only two values, we can also make it a boolean value. I plan to merge this PR and then I will submit a follow on to remove the use of unreachable!
| match kw { | ||
| Keyword::LEFT => JoinOperator::LeftOuter, | ||
| Keyword::RIGHT => JoinOperator::RightOuter, | ||
| _ => unreachable!(), |
There was a problem hiding this comment.
Since it can have only two values, we can also make it a boolean value. I plan to merge this PR and then I will submit a follow on to remove the use of unreachable!
Pull Request Test Coverage Report for Build 3512324437
💛 - Coveralls |
Closes #712
Some of SQL engines support SEMI/ANTI JOIN syntax explicitly. This PR adds this support to sqlparser-rs.