Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add snowflake and generic exclude support #721

Merged
merged 1 commit into from Nov 30, 2022
Merged

feat: add snowflake and generic exclude support #721

merged 1 commit into from Nov 30, 2022

Conversation

AugustoFKL
Copy link
Contributor

The exclude clause can be used after a possibly qualified on SELECT. (1)

Refs: #716

@AugustoFKL AugustoFKL mentioned this pull request Nov 20, 2022
Closed
feat: add snowflake and generic exclude support
03f0914 
The exclude clause can be used after a possibly qualified on SELECT
@coveralls
Copy link

coveralls commented Nov 20, 2022 •
edited

Pull Request Test Coverage Report for Build 3509269036

  • 67 of 68 (98.53%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 86.327%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 19 20 95.0%
Totals Coverage Status
Change from base Build 3448124733: 0.05%
Covered Lines: 11863
Relevant Lines: 13742
💛 - Coveralls

@AugustoFKL AugustoFKL mentioned this pull request Nov 21, 2022
Closed
alamb
alamb approved these changes Nov 30, 2022
View reviewed changes
Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thank you @AugustoFKL

@alamb alamb merged commit fa6bd01 into sqlparser-rs:main Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AugustoFKL @coveralls @alamb