Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN #707

Merged
merged 1 commit into from Nov 29, 2022
Merged

Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN #707

merged 1 commit into from Nov 29, 2022

Conversation

AugustoFKL
Copy link
Contributor

  • Add support for IF NOT EXISTS on PostgreSQL (1), BigQuery (2), and Generic.
  • Add COLUMN displaying properly, to match the original query.

[1] : https://www.postgresql.org/docs/current/sql-altertable.html
[2] : https://cloud.google.com/bigquery/docs/reference/standard-sql/data-definition-language#alter_table_rename_column_statement

@coveralls
Copy link

coveralls commented Nov 13, 2022

Pull Request Test Coverage Report for Build 3455920090

  • 36 of 39 (92.31%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 86.29%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 4 5 80.0%
src/ast/ddl.rs 10 12 83.33%
Totals Coverage Status
Change from base Build 3448124733: 0.01%
Covered Lines: 11839
Relevant Lines: 13720

💛 - Coveralls

@AugustoFKL
Copy link
Contributor Author

@alamb don't want to hurry or anything, but are you waiting for anything to review this?

I have quite a few PR's in row hehe

@alamb
Copy link
Collaborator

alamb commented Nov 29, 2022

@alamb don't want to hurry or anything, but are you waiting for anything to review this?

No I am not waiting on anything. I will try and find time to work through the sqlparser-rs review backlog. Thanks for bringing it to my attention

Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @AugustoFKL

@alamb alamb changed the title feat: add INE for ALTER TABLE ADD COLUMN Support for ALTER TABLE ADD COLUMN Nov 29, 2022
@alamb alamb changed the title Support for ALTER TABLE ADD COLUMN Support for IF NOT EXISTS in ALTER TABLE ADD COLUMN Nov 29, 2022
@alamb alamb merged commit 886875f into sqlparser-rs:main Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants