New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CREATE TABLE x AS TABLE y
#704
Conversation
Pull Request Test Coverage Report for Build 3587526224
💛 - Coveralls |
Hi @alamb, let me know if these updates look reasonable 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay in review @sarahyurick -- this is looking better but not quite ready yet I think
@@ -84,7 +84,7 @@ pub enum SetExpr { | |||
}, | |||
Values(Values), | |||
Insert(Statement), | |||
// TODO: ANSI SQL supports `TABLE` here. | |||
Table(Box<Table>), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Thanks @alamb ! Updated to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sarahyurick -- I think this PR now looks good. I have some ideas of how to simplify the code a little more but I'll make a follow on PR with that change.
Thanks again for sticking with this
Closes #614
My solution was to parse
CREATE TABLE x AS TABLE y
the same asCREATE TABLE x AS SELECT * FROM y
.