Modifier support for Custom Datatype #680
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PostgreSQL/PostGIS, when creating tables with
geometry
orgeography
data type, additional modifiers are allowed. In this example, we can specifygeography(POINT, 4269)
as data type, which indicates the column is geography point typed, and uses 4269 as its spatial reference system.Back to sqlparser, at the moment we don't support
Custom
data type that comes with additional modifiers/arguments in form of(..)
. This patch add support for that. Since these data can be in any form like an identifier, a number or a string, here I convert all of them intoString
. Suggestions are welcomed.Edit: In PostGIS this is called type modifiers.