Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for CHARACTER LARGE OBJECT[(p)] and CHAR LARGE OBJECT[(p)] #671

Merged
merged 1 commit into from Oct 15, 2022
Merged

Support for CHARACTER LARGE OBJECT[(p)] and CHAR LARGE OBJECT[(p)] #671

merged 1 commit into from Oct 15, 2022

Conversation

AugustoFKL
Copy link
Contributor

@AugustoFKL AugustoFKL commented Oct 14, 2022 •
edited by alamb

  • Adding support for CHARACTER LARGE OBJECT[(p)] and CHAR LARGE OBJECT[(p)], both defined on ANSI (1).
  • Add tests for both and CLOB[(p)].

(1) : https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html#character-large-object-type

Support for ANSI CHARACTER LARGE OBJECT[(p)] and `CHAR LARGE OBJECT…
c40842c 
…[(p)]`.

Add tests for both and `CLOB[(p)]`.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3246980821

  • 17 of 17 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 85.841%
Totals Coverage Status
Change from base Build 3227007003: 0.02%
Covered Lines: 10537
Relevant Lines: 12275
💛 - Coveralls

alamb
alamb approved these changes Oct 15, 2022
View reviewed changes
Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't run into CLOB's since my days at Oracle!

Thanks @AugustoFKL

@alamb alamb merged commit b42632f into sqlparser-rs:main Oct 15, 2022
@AugustoFKL AugustoFKL deleted the support-all-ansii-large-character-objects-with-opt-precision branch November 5, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AugustoFKL @coveralls @alamb