Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ON CONFLICT and RETURNING #666

Merged
merged 5 commits into from Nov 11, 2022
Merged

Implement ON CONFLICT and RETURNING #666

merged 5 commits into from Nov 11, 2022

Conversation

main--
Copy link
Contributor

@main-- main-- commented Oct 10, 2022

Implement the ON CONFLICT and RETURNING extensions as used in e.g. PostgreSQL and Sqlite.

Fixes #60.

@alamb
Copy link
Collaborator

alamb commented Oct 19, 2022

CI is failing on this PR. Marking as draft

@alamb alamb marked this pull request as draft October 19, 2022 21:19
@coveralls
Copy link

coveralls commented Oct 25, 2022

Pull Request Test Coverage Report for Build 3444008600

  • 117 of 126 (92.86%) changed or added relevant lines in 5 files are covered.
  • 1023 unchanged lines in 17 files lost coverage.
  • Overall coverage increased (+0.5%) to 86.283%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 24 25 96.0%
src/ast/mod.rs 25 33 75.76%
Files with Coverage Reduction New Missed Lines %
src/lib.rs 2 10.0%
src/test_utils.rs 2 83.58%
tests/sqlparser_bigquery.rs 6 94.29%
tests/sqlparser_sqlite.rs 6 94.87%
src/ast/value.rs 8 87.67%
tests/sqlparser_clickhouse.rs 8 95.09%
tests/sqlparser_hive.rs 8 96.54%
tests/sqlparser_mssql.rs 8 94.7%
tests/sqlparser_redshift.rs 9 93.57%
tests/sqlparser_snowflake.rs 9 93.67%
Totals Coverage Status
Change from base Build 3209998484: 0.5%
Covered Lines: 11675
Relevant Lines: 13531

💛 - Coveralls

@alamb alamb marked this pull request as ready for review October 25, 2022 16:40
Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution @main-- Can you please add tests to this PR?

@alamb alamb marked this pull request as draft October 25, 2022 16:40
@baoyachi
Copy link

Is there any update 🦀 @alamb

@main--
Copy link
Contributor Author

main-- commented Oct 31, 2022

@baoyachi I think right now @alamb is waiting for me to write tests that make sure that the new functionality actually works. I don't have the bandwidth to work on this right now, however.

If you're interested in moving this PR forward, you could write some tests and I would be happy to merge them onto my branch to make them part of this PR. :)

@alamb
Copy link
Collaborator

alamb commented Oct 31, 2022

Yes, I think this PR needs tests before it can be merged. Also I plan to invest some time today working down the outstanding sqlparser-rs review backlog. FYI @AugustoFKL

@main-- main-- marked this pull request as ready for review November 11, 2022 09:39
Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me -- thank you @main--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostgreSQL RETURNING Data From Modified Rows
4 participants