New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ON CONFLICT and RETURNING #666
Conversation
CI is failing on this PR. Marking as draft |
Pull Request Test Coverage Report for Build 3444008600
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @main-- Can you please add tests to this PR?
Is there any update 🦀 @alamb |
@baoyachi I think right now @alamb is waiting for me to write tests that make sure that the new functionality actually works. I don't have the bandwidth to work on this right now, however. If you're interested in moving this PR forward, you could write some tests and I would be happy to merge them onto my branch to make them part of this PR. :) |
Yes, I think this PR needs tests before it can be merged. Also I plan to invest some time today working down the outstanding sqlparser-rs review backlog. FYI @AugustoFKL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me -- thank you @main--
Implement the ON CONFLICT and RETURNING extensions as used in e.g. PostgreSQL and Sqlite.
Fixes #60.