Support optional unit (CHARACTER or OCTET) for character string types such as VARCHAR
#663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…types. This results in complete support for ANSI CHARACTER, CHAR, CHARACTER VARYING, CHAR VARYING, and VARCHAR.
Pull Request Test Coverage Report for Build 3214905321
💛 - Coveralls |
alamb
approved these changes
Oct 11, 2022
alamb
changed the title
CHARACTER or OCTET) for character string types such as VARCHAR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for optional
OCTETSandCHARACTERSafter the precision. I haven't seen that syntax for any big dialects that I remember but, since ANSI supports it (1), I wanted to add the possible syntax.@alamb ready for review :)
[1] : https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html#character-string-type
Related to: #661