Enum to handle exact number precisios #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3207622076
💛 - Coveralls |
alamb
reviewed
Oct 7, 2022
src/ast/data_type.rs
Outdated
| /// Additional information for `NUMERIC`, `DECIMAL`, and `DEC` data types | ||
| /// following the 2016 [standard]. | ||
| /// | ||
| /// [standard]: https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html#datetime-type |
There was a problem hiding this comment.
this link seems incorrect (as it points to datetime-type)?
| @@ -3467,10 +3467,9 @@ impl<'a> Parser<'a> { | |||
| Keyword::STRING => Ok(DataType::String), | |||
| Keyword::TEXT => Ok(DataType::Text), | |||
| Keyword::BYTEA => Ok(DataType::Bytea), | |||
| Keyword::NUMERIC | Keyword::DECIMAL | Keyword::DEC => { | |||
| let (precision, scale) = self.parse_optional_precision_scale()?; | |||
There was a problem hiding this comment.
parse_optional_precision_scale
is this function still used anywhere? If not shall we remove it? If so, perhaps there are other places that should be migrated over?
There was a problem hiding this comment.
It is used in another place, in the parser as well. TBH I didn't review the logic for the other usage, maybe it ends in the same problem, but I'll take a look in another moment.
I think it can be left like that for now.
alamb
approved these changes
Oct 7, 2022
|
Thanks @AugustoFKL |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of an enum to handle Decimal (1) precision and scale, instead of options, for two reasons:
DATETIME (p,s), ifsis some, necessarilypis some).Since we already didn't accept the
DECIMALdata type only with scale, that doesn't change the behavior.[1] : https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html#exact-numeric-type