Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timestamp print format based on input #640

Closed
AugustoFKL opened this issue Sep 30, 2022 · 0 comments · Fixed by #641
Closed

Timestamp print format based on input #640

AugustoFKL opened this issue Sep 30, 2022 · 0 comments · Fixed by #641

Comments

@AugustoFKL
Copy link
Contributor

AugustoFKL commented Sep 30, 2022

TIMESTAMP WITH TIME ZONE and TIMESTAMPTZ theoretically are the same on Postgresql (1), but they are not for other dialects like Oracle(2) (that doesn't support TIMESTAMPTZ). Therefore, we should parse EXACTLY the same timestamp info as input and output, instead of losing its conversion.

The standard only supports TIMESTAMP WITH TIMEZONE(3)

This applies to TIME as well.

[1] : https://www.postgresql.org/docs/current/datatype-datetime.html
[2] : https://docs.oracle.com/en/database/oracle/oracle-database/12.2/nlspg/datetime-data-types-and-time-zone-support.html#GUID-3F1C388E-C651-43D5-ADBC-1A49E5C2CA05
[3] : https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html#datetime-type
Fixes: #589

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant