Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optional precision for CLOB and BLOB #639

Merged
merged 3 commits into from Oct 1, 2022
Merged

Support optional precision for CLOB and BLOB #639

merged 3 commits into from Oct 1, 2022

Conversation

AugustoFKL
Copy link
Contributor

@coveralls
Copy link

coveralls commented Sep 30, 2022

Pull Request Test Coverage Report for Build 3166179941

  • 20 of 20 (100.0%) changed or added relevant lines in 3 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 85.575%

Files with Coverage Reduction New Missed Lines %
src/parser.rs 5 82.87%
Totals Coverage Status
Change from base Build 3166118200: -0.03%
Covered Lines: 10180
Relevant Lines: 11896

💛 - Coveralls

@AugustoFKL
Copy link
Contributor Author

@alamb I found a bug concerning TIMESTAMP. I'll create a fix for that.

For today, I'll not add anything, possibly tomorrow. Maybe we can have a hotfix for now?

@alamb alamb changed the title 638 Adjusting CLOB and BLOB with optional precision Support optional precision for CLOB and BLOB Oct 1, 2022
Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful -- thank you @AugustoFKL

@alamb
Copy link
Collaborator

alamb commented Oct 1, 2022

@AugustoFKL can you please resolve the conflicts in this PR and then I will merge it? Thank you

@AugustoFKL
Copy link
Contributor Author

@AugustoFKL can you please resolve the conflicts in this PR and then I will merge it? Thank you

Done! @alamb please LMK if I should follow another pattern, but I usually rebase and force-update the PRs.

Is that ok?

@alamb
Copy link
Collaborator

alamb commented Oct 1, 2022

Done! @alamb please LMK if I should follow another pattern, but I usually rebase and force-update the PRs.

Thanks! In general when reviewing PRs I find it easier to review merges rather than rebases (as then it is clear what has changed since I last reviewed). For small PRs like this one, it is fine though -- no worries

@alamb alamb merged commit fb5a974 into sqlparser-rs:main Oct 1, 2022
@alamb
Copy link
Collaborator

alamb commented Oct 1, 2022

Thanks again @AugustoFKL

@alamb
Copy link
Collaborator

alamb commented Oct 1, 2022

For today, I'll not add anything, possibly tomorrow. Maybe we can have a hotfix for now?

What do you mean by "hotfix" -- would you like me to release a new version of sqlparser-rs?

@AugustoFKL
Copy link
Contributor Author

For today, I'll not add anything, possibly tomorrow. Maybe we can have a hotfix for now?

What do you mean by "hotfix" -- would you like me to release a new version of sqlparser-rs?

Would it be possible, like, in the next week? I mean, if possible of course. Sorry if it looked like I was rushing or something like that

@alamb
Copy link
Collaborator

alamb commented Oct 1, 2022

Would it be possible, like, in the next week? I mean, if possible of course. Sorry if it looked like I was rushing or something like that

Sure -- no problem -- the releases are fairly small overhead these days. I'll get it done over the next day or two

@alamb
Copy link
Collaborator

alamb commented Oct 3, 2022

I released version 0.25.0: https://crates.io/crates/sqlparser/0.25.0

@AugustoFKL AugustoFKL deleted the 638_blob-and-clob-fixes branch October 4, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix CLOB and BLOB precision
3 participants