New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support optional precision for CLOB
and BLOB
#639
Conversation
Pull Request Test Coverage Report for Build 3166179941
💛 - Coveralls |
@alamb I found a bug concerning For today, I'll not add anything, possibly tomorrow. Maybe we can have a hotfix for now? |
CLOB
and BLOB
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful -- thank you @AugustoFKL
@AugustoFKL can you please resolve the conflicts in this PR and then I will merge it? Thank you |
Done! @alamb please LMK if I should follow another pattern, but I usually rebase and force-update the PRs. Is that ok? |
Thanks! In general when reviewing PRs I find it easier to review merges rather than rebases (as then it is clear what has changed since I last reviewed). For small PRs like this one, it is fine though -- no worries |
Thanks again @AugustoFKL |
What do you mean by "hotfix" -- would you like me to release a new version of sqlparser-rs? |
Would it be possible, like, in the next week? I mean, if possible of course. Sorry if it looked like I was rushing or something like that |
Sure -- no problem -- the releases are fairly small overhead these days. I'll get it done over the next day or two |
I released version |
Adding optional precision for
CLOB
(1) andBLOB
(2)[1] : https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html#character-large-object-type
[2] : https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html#binary-large-object-string-type
Resolves: #638
Fixes: #618
@alamb first one. 2 more to come :D