Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding mediumint support #630

Merged
merged 1 commit into from Sep 28, 2022
Merged

Adding mediumint support #630

merged 1 commit into from Sep 28, 2022

Conversation

AugustoFKL
Copy link
Contributor

@AugustoFKL AugustoFKL commented Sep 27, 2022 •
edited

Adding MySQ's mediumint support(1)

Other INT types are already supported (e.g., MySQL's BIGINT), so adding MEDIUMINT should be a problem...

[1] : https://dev.mysql.com/doc/refman/8.0/en/integer-types.html
Resolves: #625

@AugustoFKL AugustoFKL changed the title #625 adding mediumint support Adding mediumint support Sep 27, 2022
alamb
alamb approved these changes Sep 28, 2022
View reviewed changes
Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AugustoFKL -- looks good to me

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3138006940

  • 21 of 22 (95.45%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 85.516%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 5 6 83.33%
Totals Coverage Status
Change from base Build 3137828198: 0.01%
Covered Lines: 10120
Relevant Lines: 11834
💛 - Coveralls

@alamb alamb merged commit e951cd5 into sqlparser-rs:main Sep 28, 2022
@AugustoFKL AugustoFKL deleted the 625_mediutint-datatype-support branch October 4, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MySQL's MEDIUMINT support
3 participants
@AugustoFKL @coveralls @alamb