Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding DOUBLE PRECISION to data types, parsing it, and tests #629

Merged
merged 1 commit into from Sep 28, 2022
Merged

Adding DOUBLE PRECISION to data types, parsing it, and tests #629

merged 1 commit into from Sep 28, 2022

Conversation

AugustoFKL
Copy link
Contributor

Adding DOUBLE PRECISION correct support(1) (2).

Since PostgreSQL doesn't accept DOUBLE, we should differentiate it from DOUBLE PRECISION when parsing it. More description is on the related issue (3)

[1] : https://jakewheat.github.io/sql-overview/sql-2016-foundation-grammar.html#approximate-numeric-type
[2] : https://www.postgresql.org/docs/current/datatype-numeric.html
[3] : #622

@AugustoFKL AugustoFKL changed the title Adding DOUBLE PRECISION to data types, parsing it, and tests #629 Adding DOUBLE PRECISION to data types, parsing it, and tests Sep 27, 2022
@AugustoFKL AugustoFKL changed the title #629 Adding DOUBLE PRECISION to data types, parsing it, and tests Adding DOUBLE PRECISION to data types, parsing it, and tests Sep 27, 2022
@AugustoFKL AugustoFKL changed the title Adding DOUBLE PRECISION to data types, parsing it, and tests #622 Adding DOUBLE PRECISION to data types, parsing it, and tests Sep 27, 2022
@AugustoFKL AugustoFKL changed the title #622 Adding DOUBLE PRECISION to data types, parsing it, and tests Adding DOUBLE PRECISION to data types, parsing it, and tests Sep 27, 2022
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3137733703

  • 9 of 9 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 85.556%

Totals Coverage Status
Change from base Build 3136407158: 0.009%
Covered Lines: 10087
Relevant Lines: 11790

💛 - Coveralls

@alamb alamb merged commit 46b7c03 into sqlparser-rs:main Sep 28, 2022
@AugustoFKL AugustoFKL deleted the 622_postgresql-double-precision-support branch October 4, 2022 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants