Fix parsing CLOB, BINARY, VARBINARY, BLOB data type

[ding-young]

Related Issue

Resolves #518

Description

Parse error occurs for CLOB, BINARY, VARBINARY, and BLOB data types though they are included as variants for data type & keywords in sqlparser. Since all these 4 data types contain (non-optional) u64 value, added parse_precision fn.

[coveralls]

Pull Request Test Coverage Report for Build 3141114749

• 33 of 35 (94.29%) changed or added relevant lines in 2 files are covered.
• 730 unchanged lines in 7 files lost coverage.
• Overall coverage decreased (-0.008%) to 85.58%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/parser.rs	5	7	71.43%

Files with Coverage Reduction	New Missed Lines	%
src/test_utils.rs	1	83.58%
tests/sqlparser_postgres.rs	5	97.72%
src/ast/value.rs	8	88.06%
src/tokenizer.rs	46	89.42%
tests/sqlparser_common.rs	83	97.07%
src/ast/mod.rs	267	77.22%
src/parser.rs	320	83.02%

Totals
Change from base Build 3090626203:	-0.008%
Covered Lines:	10143
Relevant Lines:	11852

---

💛 - Coveralls

[alamb]

Thank you for this @ding-young -- the code looks good. Can you please add regression tests so that this syntax is not accidentally broken in the future?

Thank you

[ding-young]

@alamb I added test cases for parse_cast with these data types since I could not find test fn parse_datatype.. Thanks for review.

[alamb]

LGTM -- thanks @ding-young

[AugustoFKL]

@alamb @ding-young

CREATE TABLE tb (id BINARY); works on MySQL, so the precision is actually optional

The same for CREATE TABLE tb_3 (id BLOB);

This seems a regression of support for me.

[AugustoFKL]

As the standard shows, BINARY and BLOB have optional precision

[alamb]

Thanks for the report @AugustoFKL -- any chance you can make a PR to fix it?

[AugustoFKL]

@alamb sure, I can do it today

I also need to add precision to TIMESTAMP, TIMESTAMPZ, DATETIME, and TIME, can you wait for those before a new release, please?

I don't like to do multiple things in one PR, so I'll possibly open two (or one for each one?)

[alamb]

Multiple small PRs would be most preferable. 🙏