Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add overlay expr #594

Merged
merged 4 commits into from Aug 26, 2022
Merged

Add overlay expr #594

merged 4 commits into from Aug 26, 2022

Conversation

ayushdg
Copy link
Contributor

@ayushdg ayushdg commented Aug 26, 2022

Fixes: #593
This pr adds support for the overlay syntax See https://www.postgresql.org/docs/current/functions-string.html.

  • Add high level overlay expr
  • Add parsing logic for overlay
  • Add tests

The pr also adds a few tests cases for is not true/false and is [not] unknown added in #582

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2935823468

  • 58 of 66 (87.88%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 85.537%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/sqlparser_common.rs 31 34 91.18%
src/ast/mod.rs 10 15 66.67%
Files with Coverage Reduction New Missed Lines %
tests/sqlparser_common.rs 1 96.93%
Totals Coverage Status
Change from base Build 2889184458: 0.07%
Covered Lines: 9670
Relevant Lines: 11305

💛 - Coveralls

Copy link
Collaborator

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @ayushdg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Postgres OVERLAY syntax
3 participants