Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support LOCALTIME and LOCALTIMESTAMP time functions #592

Merged

Conversation

MazterQyou
Copy link
Contributor

@MazterQyou MazterQyou commented Aug 25, 2022

This PR adds support for parsing LOCALTIME and LOCALTIMESTAMP without parentheses as a time function with no arguments (see https://www.postgresql.org/docs/14/functions-datetime.html#FUNCTIONS-DATETIME-CURRENT). It also adds related tests.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2925523053

  • 18 of 23 (78.26%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.007%) to 85.459%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 0 5 0.0%
Totals Coverage Status
Change from base Build 2889184458: -0.007%
Covered Lines: 9627
Relevant Lines: 11265

💛 - Coveralls

Copy link
Collaborator

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Will merge next week if there are no objections.

cc @waitingkuo

@andygrove andygrove merged commit 0bb49ce into sqlparser-rs:main Aug 30, 2022
@joocer joocer mentioned this pull request Sep 12, 2022
32 tasks
@MazterQyou MazterQyou deleted the upstream-patch/localtime-localtimestamp branch September 27, 2022 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants