Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IS NOT TRUE, IS NOT FALSE, and IS [NOT] UNKNOWN #583

Merged
merged 1 commit into from Aug 18, 2022
Merged

Add IS NOT TRUE, IS NOT FALSE, and IS [NOT] UNKNOWN #583

merged 1 commit into from Aug 18, 2022

Conversation

sarahyurick
Copy link
Contributor

Closes #582

Previously, sqlparser did not support "is not true," "is not false," "is unknown," and "is not unknown," so I have added them here.

Copy link
Collaborator

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sarahyurick. This seems to follow the pattern we use for other IS expressions such as IsNull / IsNotNull, so LGTM.

@andygrove
Copy link
Collaborator

Link to Postgres documentation on these expressions for anyone interested:

https://www.postgresql.org/docs/current/functions-comparison.html

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2878598801

  • 4 of 12 (33.33%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.06%) to 85.377%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 0 4 0.0%
src/parser.rs 4 8 50.0%
Files with Coverage Reduction New Missed Lines %
src/ast/mod.rs 1 77.65%
Totals Coverage Status
Change from base Build 2877505870: -0.06%
Covered Lines: 9511
Relevant Lines: 11140

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support IS NOT TRUE, IS NOT FALSE, and IS [NOT] UNKNOWN
3 participants