Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Box Query in Cte #572

Merged
merged 1 commit into from Sep 27, 2022
Merged

Conversation

MazterQyou
Copy link
Contributor

@MazterQyou MazterQyou commented Aug 12, 2022

Cte is the only struct that has Query unboxed; all other instances are Boxed. I propose Boxing Query in Cte for the sake of interoperability and keeping things similar, thus the PR contains the proposed change.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2848948795

  • 3 of 3 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.001%) to 85.446%

Totals Coverage Status
Change from base Build 2848542264: 0.001%
Covered Lines: 9499
Relevant Lines: 11117

💛 - Coveralls

Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is fine with me, however, there is already some discussion about un Boxing the Query in Statement 🤔

#556

cc @ever0de and @andygrove

@alamb
Copy link
Collaborator

alamb commented Sep 27, 2022

The conclusion from #556 is that Boxing is the pattern and we will stick to it.

@alamb alamb merged commit 0724ef1 into sqlparser-rs:main Sep 27, 2022
@MazterQyou MazterQyou deleted the upstream-patch/box-cte-query branch September 27, 2022 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants