Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SHOW COLLATION #564

Merged
merged 1 commit into from Aug 11, 2022

Conversation

MazterQyou
Copy link
Contributor

This PR adds support for MySQL-specific SHOW COLLATION statement with full syntax support, as well as a related test.

@coveralls
Copy link

coveralls commented Aug 9, 2022

Pull Request Test Coverage Report for Build 2840047609

  • 24 of 24 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.981%

Totals Coverage Status
Change from base Build 2839791289: 0.02%
Covered Lines: 9313
Relevant Lines: 10350

💛 - Coveralls

Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks @MazterQyou

@alamb
Copy link
Collaborator

alamb commented Aug 11, 2022

@MazterQyou -- github shows that this PR has conflicts that must be resolved (likely with #559) -- can you please resolve them (probably needs a merge from main)

@alamb alamb marked this pull request as draft August 11, 2022 10:45
@alamb alamb marked this pull request as ready for review August 11, 2022 11:02
@MazterQyou
Copy link
Contributor Author

This PR is almost guaranteed to conflict with #563 so I'll wait for that to be merged first, then rebase.

@alamb
Copy link
Collaborator

alamb commented Aug 11, 2022

#563 has been merged

@MazterQyou MazterQyou force-pushed the upstream-patch/show-collation branch from cc29d03 to bb34268 Compare August 11, 2022 13:14
@MazterQyou
Copy link
Contributor Author

@alamb rebased the PR branch and also extended another test in sqlparser_mysql.rs, please re-review.

@MazterQyou MazterQyou requested a review from alamb August 11, 2022 13:17
Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MazterQyou

@alamb alamb merged commit 18881f8 into sqlparser-rs:main Aug 11, 2022
@MazterQyou MazterQyou deleted the upstream-patch/show-collation branch August 11, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants