New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support full SHOW TABLES
syntax
#563
Conversation
Pull Request Test Coverage Report for Build 2839397720
💛 - Coveralls |
a6a1e74
to
59c37e9
Compare
self.expect_one_of_keywords(&[Keyword::COLUMNS, Keyword::FIELDS])?; | ||
pub fn parse_show_columns( | ||
&mut self, | ||
extended: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 nice refactoring of this into the common parse_show
assert!(mysql_and_generic() | ||
.parse_sql_statements("SHOW EXTENDED FULL COLUMNS FROM mytable") | ||
.is_ok()); | ||
// SHOW EXTENDED/FULL can only be used with COLUMNS and TABLES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great tests 🏅
@@ -1012,6 +1012,15 @@ pub enum Statement { | |||
table_name: ObjectName, | |||
filter: Option<ShowStatementFilter>, | |||
}, | |||
/// SHOW TABLES |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reviewed and this appears to match https://dev.mysql.com/doc/refman/8.0/en/show-tables.html
@MazterQyou -- github says this PR has a conflict that needs to be resolved. Can you please merge up from master so I can then merge it in? Thank you |
59c37e9
to
11d68ab
Compare
@alamb rebased the PR branch to resolve the conflict 👌 |
Thanks @MazterQyou ! |
This PR adds support for MySQL-specific
SHOW TABLES
statement with full syntax support, as well as a related test.