New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Parse special keywords as functions (current_user, user, etc) #561
feat: Parse special keywords as functions (current_user, user, etc) #561
Conversation
Pull Request Test Coverage Report for Build 2839618346
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @ovr -- looks good to me except for a question about the special
field
@@ -2243,20 +2243,27 @@ pub struct Function { | |||
pub over: Option<WindowSpec>, | |||
// aggregate functions may specify eg `COUNT(DISTINCT x)` | |||
pub distinct: bool, | |||
pub special: bool, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why a special
field is needed ? Wouldn't it be enough to match on the name
?
If we do need a special
field, can you please add a ///
comment explaining what it means and what it is used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marking this as a draft to show it is waiting some changes so I can easily filter out which PRs need review. Please mark it as "ready for review" when it is next ready. |
8b700ff
to
a6a3340
Compare
Thanks @ovr |
Hello!
https://www.postgresql.org/docs/9.1/functions-info.html
Thanks