Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is generated always as identity not supported. #560

Closed
samjay000 opened this issue Aug 8, 2022 · 4 comments
Closed

Is generated always as identity not supported. #560

samjay000 opened this issue Aug 8, 2022 · 4 comments

Comments

@samjay000
Copy link
Contributor

When trying to parse

CREATE TABLE table2
(
    column21 bigint primary key generated always as identity,
    column22 text
);

let ast: Vec<ast::Statement> = SQLParser::parse_sql(&dialect, &contents).unwrap();

dialect = PostgreSqlDialect
contents = above DDL

Will produce

ParserError("Expected ',' or ')' after column definition, found: generated")

Above DDL is valid on PostgreSQL.
Am I doing something wrong or is generated always as identity not supported?

@AugustoFKL
Copy link
Contributor

@sam-mmm that's a constraint not supported yet.

@samjay000
Copy link
Contributor Author

samjay000 commented Oct 3, 2022

Thanks,

this pull request covers it #587

@AugustoFKL
Copy link
Contributor

@sam-mmm can't that be reduced to smaller PRs?

Having a huge PR with different concepts makes it hard to review. You're dealing with 3 different problems at least, that could be 3 different PRs.

@samjay000
Copy link
Contributor Author

@AugustoFKL I have closed PR #587 and created PR #673

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants