Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support SET NAMES literal [COLLATE literal] #558

Merged
merged 3 commits into from Aug 11, 2022

Conversation

ovr
Copy link
Contributor

@ovr ovr commented Aug 8, 2022

Hello!

https://dev.mysql.com/doc/refman/8.0/en/set-names.html

SET NAMES {'charset_name'
    [COLLATE 'collation_name'] | DEFAULT}

Thanks

@coveralls
Copy link

coveralls commented Aug 8, 2022

Pull Request Test Coverage Report for Build 2817986477

  • 40 of 43 (93.02%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.974%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 10 13 76.92%
Totals Coverage Status
Change from base Build 2805421159: 0.02%
Covered Lines: 9136
Relevant Lines: 10154

💛 - Coveralls

Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome -- thank you @ovr

@alamb alamb merged commit 221e9c2 into sqlparser-rs:main Aug 11, 2022
@ovr ovr deleted the setname-pr branch August 11, 2022 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants