Boxed Query body to save some stack space #540
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boxing
Query::body
reduced size ofQuery
from 1312B to 592B.In following test of standalone parser runs (7MB stack) allowed subquery nesting jumped from 239 to 286.
This makes significant difference when parsing "recursive queries" in environments with reduced stack size (e.g. like tokio spawned threads - 2MB).