New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for AT TIME ZONE
#539
Add support for AT TIME ZONE
#539
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good to me. Once #532 is merged let's rebase this one and merge it in
@@ -285,6 +285,11 @@ pub enum Expr { | |||
expr: Box<Expr>, | |||
data_type: DataType, | |||
}, | |||
/// AT a timestamp to a different timezone e.g. `FROM_UNIXTIME(0) AT TIME ZONE 'UTC-06:00'` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Test Coverage Report for Build 2691581309
馃挍 - Coveralls |
f2a33a7
to
9d12e85
Compare
9d12e85
to
0a897d2
Compare
@alamb rebases all around, fmt issues should be fixed now. |
Thank you @bitemyapp ! |
* Support for empty array literals * Added support for AT TIME ZONE Co-authored-by: Chris Allen <chrisa@indeed.com>
* Support for empty array literals * Added support for AT TIME ZONE Co-authored-by: Chris Allen <chrisa@indeed.com> qwe
* Support for empty array literals * Added support for AT TIME ZONE Co-authored-by: Chris Allen <chrisa@indeed.com> qwe
Builds off #532, this time to add support for
AT TIME ZONE
which appears in multiple SQL dialects including Athena/Presto and MSSQL. There may be others, I haven't bothered to check. I can rebase if #532 gets merged first.This one was a bit harder. The precedence value is pure guessery: "uhhhh kinda looks like
BETWEEN
?"All tests passed locally 馃