Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support double quoted string in MySql and BigQuery dialects #530

Merged
merged 1 commit into from Jun 28, 2022

Conversation

komukomo
Copy link
Contributor

@komukomo komukomo commented Jun 28, 2022

ref. #439

Support double quoted string for BigQuery and MySQL.

Below is a test for other dialects.

fn parse_delimited_identifiers() {
// check that quoted identifiers in any position remain quoted after serialization
let select = verified_only_select(
r#"SELECT "alias"."bar baz", "myfun"(), "simple id" AS "column alias" FROM "a table" AS "alias""#,
);

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2573826050

  • 32 of 34 (94.12%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 89.801%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 1 3 33.33%
Totals Coverage Status
Change from base Build 2535757386: 0.02%
Covered Lines: 8796
Relevant Lines: 9795

💛 - Coveralls

Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @komukomo

@alamb alamb merged commit 17c238b into sqlparser-rs:main Jun 28, 2022
@alamb alamb changed the title Support double quoted string Support double quoted string in MySql and BigQuery dialects Jun 28, 2022
mobuchowski pushed a commit to mobuchowski/sqlparser-rs that referenced this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants