New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for ClickHouse DDL query syntax (on cluster
)
#527
Merged
alamb
merged 5 commits into
sqlparser-rs:main
from
andyrichardson:add-on-cluster-support
Jul 28, 2022
Merged
Add support for ClickHouse DDL query syntax (on cluster
)
#527
alamb
merged 5 commits into
sqlparser-rs:main
from
andyrichardson:add-on-cluster-support
Jul 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyrichardson
changed the title
Add support for ON_CLUSTER on CREATE TABLE statement
Add support for ClickHouse DDL query syntax (Jun 24, 2022
on cluster
)
alamb
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great -- thank you @andyrichardson. I think adding support for other DDL statements sounds like a great idea.
The only possible thing that might be worth considering is to only parse ON CLUSTER
when using the generic
and ClickHouse
dialects
Pull Request Test Coverage Report for Build 2755925293
💛 - Coveralls |
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
alamb
reviewed
Jul 28, 2022
mobuchowski
pushed a commit
to mobuchowski/sqlparser-rs
that referenced
this pull request
Aug 3, 2022
…-rs#527) * Add on_cluster to Statement::CreateTable * Add printing of on_cluster * Update src/ast/mod.rs Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org> * Fix fmt + nostd * Remove unintended diff Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for ClickHouse DDL query syntax (source)
This is an example only on
CREATE TABLE
statements. If you're happy to go ahead with supporting this, I can add this to allCREATE
DROP
ALTER
andRENAME
queries