fix: Support expr
instead of string
for argument to interval
#517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Big Query and MySQL, the following query is valid:
https://cloud.google.com/bigquery/docs/reference/standard-sql/date_functions#date_add
https://www.w3schools.com/mysql/func_mysql_date_add.asp
But now if the expression is number, an error occurred because the type of the value in
interval
isString
sqlparser-rs/src/ast/value.rs
Line 53 in ca15a4e
This PR replaces
String
withExpr
to run correctly inInterval
One concern thing is that should I validate when the other dialect like
PostgresSQL
,sqlite
. I don't know if the query is valid except for Big query and MySQL.