Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for FETCH cursor #510

Merged
merged 1 commit into from Jun 4, 2022
Merged

Add support for FETCH cursor #510

merged 1 commit into from Jun 4, 2022

Conversation

ovr
Copy link
Contributor

@ovr ovr commented May 25, 2022

Hello!

Thanks

@ovr ovr marked this pull request as ready for review May 25, 2022 16:12
@coveralls
Copy link

coveralls commented May 25, 2022 •
edited

Pull Request Test Coverage Report for Build 2396466229

  • 84 of 86 (97.67%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 89.73%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/mod.rs 35 37 94.59%
Files with Coverage Reduction New Missed Lines %
src/ast/mod.rs 1 78.46%
Totals Coverage Status
Change from base Build 2395967002: 0.07%
Covered Lines: 8632
Relevant Lines: 9620
💛 - Coveralls

alamb
alamb approved these changes Jun 4, 2022
View reviewed changes
Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- thank you @ovr this looks good

src/ast/mod.rs
/// Specific direction for FETCH statement
#[derive(Debug, Clone, PartialEq, Eq, Hash)]
#[cfg_attr(feature = "serde", derive(Serialize, Deserialize))]
pub enum FetchDirection {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.postgresql.org/docs/current/sql-fetch.html 👍

@alamb alamb merged commit 66a3082 into sqlparser-rs:main Jun 4, 2022
@alamb alamb changed the title feat: Support FETCH (cursors) Add support for FETCH cursor Jun 4, 2022
mobuchowski pushed a commit to mobuchowski/sqlparser-rs that referenced this pull request Aug 3, 2022
@ovr @mobuchowski
feat: Support FETCH (cursors) (sqlparser-rs#510)
aeea11c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ovr @coveralls @alamb