Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initial support for DECLARE (cursors) #509

Merged
merged 1 commit into from Jun 6, 2022

Conversation

ovr
Copy link
Contributor

@ovr ovr commented May 25, 2022

Hello!

It requires support for arguments, but it's a good initial point for supporting DECLARE.

Thanks

@coveralls
Copy link

coveralls commented May 25, 2022

Pull Request Test Coverage Report for Build 2446379753

  • 56 of 59 (94.92%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 89.772%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 24 25 96.0%
src/ast/mod.rs 23 25 92.0%
Files with Coverage Reduction New Missed Lines %
src/ast/mod.rs 1 78.76%
Totals Coverage Status
Change from base Build 2440505971: 0.03%
Covered Lines: 8698
Relevant Lines: 9689

💛 - Coveralls

@ovr ovr marked this pull request as ready for review May 25, 2022 13:54
@ovr ovr force-pushed the declare-pr branch 4 times, most recently from 3b0e126 to 86cd1fc Compare May 27, 2022 12:20
Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ovr

@alamb
Copy link
Collaborator

alamb commented Jun 4, 2022

@ovr thank you -- For some reason github says this PR has a conflict -- can you possibly do so and I'll merge it in?

Thanks again!

Screen Shot 2022-06-04 at 2 28 21 PM

@ovr
Copy link
Contributor Author

ovr commented Jun 6, 2022

@alamb Rebased ✅

Copy link
Collaborator

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great -- thanks again @ovr

@alamb alamb merged commit 3f1c642 into sqlparser-rs:main Jun 6, 2022
mobuchowski pushed a commit to mobuchowski/sqlparser-rs that referenced this pull request Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants