Support hive CREATE FUNCTION syntax
#496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2390143654
💛 - Coveralls |
alamb
approved these changes
May 22, 2022
There was a problem hiding this comment.
LGTM -- thank you @mobuchowski
What do you think about conditionalizing this on being part of the hive Dialect?
|
This PR appears to have a merge conflict now. Also, @mobuchowski are you planning to implement #496 (comment) in this PR, or shall we file a ticket for a follow on task? |
|
Sorry, had a busy week. I'll fix the conflict and implement the conditional tomorrow. |
I totally understand! |
Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
mobuchowski
force-pushed
the
add-create-function
branch
from
0f64758
to
3613238
Compare
|
Hey @alamb, fixed the PR and added checking for HiveDialect. |
alamb
approved these changes
May 26, 2022
| }; | ||
|
|
||
| assert_eq!( | ||
| generic.parse_sql_statements(sql).unwrap_err(), |
alamb
changed the title
CREATE FUNCTION syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
CreateFunctionsyntax based on Hive: https://cwiki.apache.org/confluence/display/hive/languagemanual+ddl#LanguageManualDDL-Create/Drop/ReloadFunctionSigned-off-by: Maciej Obuchowski obuchowski.maciej@gmail.com