New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support placeholders ($
or ?
) in LIMIT
clause
#494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good -- thank you @step-baby - sorry for the delayed review
Pull Request Test Coverage Report for Build 2367505018
💛 - Coveralls |
I took the liberty of fixing |
@@ -4337,4 +4338,38 @@ mod tests { | |||
parser.prev_token(); | |||
}); | |||
} | |||
|
|||
#[test] | |||
fn test_parse_limit() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like these tests 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
#486