Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Clickhouse identifiers format #5890

Merged
merged 3 commits into from
May 20, 2024
Merged

Fix Clickhouse identifiers format #5890

merged 3 commits into from
May 20, 2024

Conversation

Pavel-Strybuk
Copy link
Contributor

Brief summary of the change made

Fixes #5889

Changes regexp to recognize Clickhouse identifiers according with documentation: https://clickhouse.com/docs/en/sql-reference/syntax#identifiers

Are there any other side effects of this change that we should be aware of?

No

Pull Request checklist

  • Please confirm you have completed any of the necessary steps below.

  • Included test cases to demonstrate any code changes, which may be one or more of the following:

    • .yml rule test cases in test/fixtures/rules/std_rule_cases.
    • .sql/.yml parser test cases in test/fixtures/dialects (note YML files can be auto generated with tox -e generate-fixture-yml).
    • Full autofix test cases in test/fixtures/linter/autofix.
    • Other.

  • Added appropriate documentation for the change.

  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

greg-finley
greg-finley approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@greg-finley greg-finley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 20, 2024 •
edited

Coverage Results ✅

Name    Stmts   Miss  Cover   Missing
-------------------------------------
TOTAL   17762      0   100%

225 files skipped due to complete coverage.

@coveralls
Copy link

coveralls commented May 20, 2024 •
edited

Coverage Status

coverage: 99.985%. remained the same
when pulling 9e99945 on Pavel-Strybuk:bugfix-5889
into d649e97 on sqlfluff:main.

@greg-finley greg-finley added this pull request to the merge queue May 20, 2024
Merged via the queue into sqlfluff:main with commit 3aae379 May 20, 2024
30 checks passed
@Pavel-Strybuk Pavel-Strybuk deleted the bugfix-5889 branch May 20, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-finley greg-finley greg-finley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't parse some identifiers when using Clickhouse dialect
4 participants
@Pavel-Strybuk @coveralls @greg-finley @gopstr