Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we make WithTx input params as interface{}? #1502

Closed
elvizlai opened this issue Mar 22, 2022 · 2 comments
Closed

Can we make WithTx input params as interface{}? #1502

elvizlai opened this issue Mar 22, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@elvizlai
Copy link

What do you want to change?

for change generated code, WithTx(tx *sql.Tx) *Queries, can we change *sql.Tx same as DBTX or other related interface?

What database engines need to be changed?

No response

What programming language backends need to be changed?

Go
@elvizlai elvizlai added enhancement New feature or request triage New issues that hasn't been reviewed labels Mar 22, 2022
@elvizlai
Copy link
Author

elvizlai commented May 1, 2022

@kyleconroy PTAL

@danielbprice
Copy link
Contributor

@elvizlai, this may be a duplicate of #383. There are some solutions illustrated there.

@kyleconroy kyleconroy removed the triage New issues that hasn't been reviewed label Aug 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kyleconroy @elvizlai @danielbprice