Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sweep for py2k install directives, such as 'wheel=universal' #351

Closed
Tracked by #340
zzzeek opened this issue Dec 20, 2021 · 1 comment
Closed
Tracked by #340

sweep for py2k install directives, such as 'wheel=universal' #351

zzzeek opened this issue Dec 20, 2021 · 1 comment
Assignees
Labels
Milestone

Comments

@zzzeek
Copy link
Member

zzzeek commented Dec 20, 2021

see sqlalchemy/alembic#893 for a similar issue in Alembic where 'wheel=universal' creates wheels targeted by py2 when people use pip. mako still has this. we should do a sweep to make sure the world of python 2 installers have zero chance of installing mako 1.2

@zzzeek zzzeek added the py3k label Dec 20, 2021
@bourke bourke added this to Active in Mako prioritization Dec 21, 2021
@bourke bourke added this to the 1.2 milestone Dec 21, 2021
@bourke bourke mentioned this issue Dec 21, 2021
8 tasks
@bourke bourke self-assigned this Dec 27, 2021
@sqla-tester
Copy link
Collaborator

Michael Bourke has proposed a fix for this issue in the main branch:

Corrected universal wheel directive; building wheels now targets Python 3 only https://gerrit.sqlalchemy.org/c/sqlalchemy/mako/+/3437

Mako prioritization automation moved this from Active to Done Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

No branches or pull requests

3 participants