Support GEOMETRY, SUPER Redshift datatypes #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jklukas
approved these changes
Nov 1, 2021
|
@jklukas -- did your test run for this change look ok? |
Thanks for the reminder. That run was flaky and errored out. I'm running a new one now. Note that since you now have commit access, you can make future PRs via a branch on this repo, which will automatically kick off the integration tests. You can also kick off integation tests for forks by verifying that the content isn't malicious, and then pushing the changeset to a branch on this repo. I use https://github.com/jklukas/git-push-fork-to-upstream-branch to manage that workflow. |
|
This change is now released in 0.8.8 |
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #209, #224. Adds support for Redshift
SUPERandGEOMETRYdatatypes.credit to @rectalogic for their approach for
SUPERdatatype support, which I've duplicated in this PR.Todos