Remove support and tests for Python 2.7 #234
Conversation
.travis.yml
Outdated
| - "3.6" | ||
| - "3.7" | ||
| - "3.8" | ||
| - "3.4" |
There was a problem hiding this comment.
I don't think we've ever found an issue that's isolated to one of these intermediate versions. Given that tests are taking longer, it seems wasteful to consume resources on running tests across 5 different python versions. It seems sufficient to me to test on the oldest supported version and the newest version. What do you think?
|
I started messing with the tox configuration here and will need to do some more playing with it to get it working. |
The next build will be 3.4+.
Good catch. Will remove. |
| - python: "3.9" | ||
| env: TOXENV=docs |
There was a problem hiding this comment.
A docs task was defined in tox.ini, but wasn't defined in the travis config. This allows it to run regularly in CI.
| @@ -16,8 +16,9 @@ The package is available on PyPI:: | |||
|
|
|||
| .. warning:: | |||
|
|
|||
| This dialect requires psycopg2 library to work properly. It does not provide | |||
| it as required, but relies on you to select the psycopg2 distribution you need: | |||
| This dialect requires either ``redshift_connector`` or ``psycopg2`` | |||
There was a problem hiding this comment.
Unrelated docs fixup. I noticed this while restoring the docs task.
| @@ -10,7 +10,6 @@ Contents: | |||
| ddl-compiler | |||
| dialect | |||
| commands | |||
| ddl | |||
There was a problem hiding this comment.
This was an error in the index; there's no rst file of this name.
| @@ -21,7 +21,7 @@ deps = | |||
| pytest==3.10.1 | |||
| requests==2.7.0 | |||
|
|
|||
| [testenv:py{36,37,38,39}-sa{13,14}] | |||
| [testenv:py39-sa14] | |||
There was a problem hiding this comment.
To reduce test runtime, I've changed the py39 test to only include sa14, and the 35 test includes only sa13. Tests can complete now in under 15 minutes.
| @@ -45,7 +45,7 @@ changedir=docs | |||
| deps= | |||
| -rrequirements-docs.txt | |||
| commands= | |||
| sphinx-build -W -b html -d {envtmpdir}/doctrees . {envtmpdir}/html | |||
| sphinx-build -b html -d {envtmpdir}/doctrees . {envtmpdir}/html | |||
There was a problem hiding this comment.
Removed the -W flag because docs generation currently fails due to warnings. I filed #239 to follow up on addressing the warnings.
The next build will be 3.4+.
Todos