Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test suite failing at collection on Python 3.10 in Pytest 7.x #323

Closed
CAM-Gerlach opened this issue Feb 26, 2022 · 1 comment · Fixed by #324
Closed

Fix test suite failing at collection on Python 3.10 in Pytest 7.x #323

CAM-Gerlach opened this issue Feb 26, 2022 · 1 comment · Fixed by #324
Assignees
Milestone

Comments

@CAM-Gerlach
Copy link
Member

CAM-Gerlach commented Feb 26, 2022

Possibly due to an updated (packaging or pytest) dependency, it looks like imports of the installed qtpy package started failing to pick up the package in recent QtPy CI test runs on Python 3.10, all platforms and install methods (it seems plausible Python 3.6 isn't failing due to not supporting the problem version of said dependency). I'm pretty sure what to look at here, so I'll go ahead and try to fix it ASAP.

@CAM-Gerlach CAM-Gerlach added this to the v2.1.0 milestone Feb 26, 2022
@CAM-Gerlach CAM-Gerlach self-assigned this Feb 26, 2022
@CAM-Gerlach CAM-Gerlach changed the title Fix failing tests on Python 3.10 due to import finding issue Fix test suite failing at collection on Python 3.10 due to import finding issue Feb 26, 2022
@CAM-Gerlach CAM-Gerlach changed the title Fix test suite failing at collection on Python 3.10 due to import finding issue Fix test suite failing at collection on Python 3.10 in Pytest 7.x Feb 26, 2022
@CAM-Gerlach
Copy link
Member Author

CAM-Gerlach commented Feb 26, 2022

After much testing, I've been able to reproduce the problem locally and isolated the problem to a regression in Pytest 7.0,0, pytest-dev/pytest#9645 with --importmode=importlib. I can confirm that it is fixed by pytest-dev/pytest#9681 , which is merged, but unfortunately they haven't yet cut another release (which will presumably be 7.0.2). For now, we can either not use --importmode=importlib, or perhaps better, just restrict pytest to ==6.* and >7.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant