Update the list of Polly voices #5723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LANGUAGE_CODES and VOICE_IDS can be created from existing VOICE_DATA so do that to eliminate need for maintainer to keep in sync.
Using actual output from aws cli as of today.
|
This is now part of moto >= 4.0.11.dev26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moto.polly.resourceswas missing some voices added by AWS since this module was first created in September 2017 (in commit fcacecb).We wanted to test code that uses "Camila", a voice for pt-BR, but that was missing so we had to monkey patch moto to add it. This PR does it properly so we can remove the monkey patch one day if this is accepted.
While I'm here, I also made the
resourcesmodule easier to maintain by:VOICE_DATAcan be obtained again in future by running anawsclicommandLANGUAGE_CODESandVOICE_IDSsets dynamically from theVOICE_DATA, so maintainers only have to update the one thing manually, not three.Had to update one test because with the addition of "Arthur" there are now 4 voices for en-GB, not 3.