Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support for etag with quotes in IfNoneMatch header #5715

Merged
merged 2 commits into from Nov 29, 2022

Conversation

macnev2013
Copy link
Contributor

@macnev2013 macnev2013 commented Nov 28, 2022

Fix

  • Ignores " if present in the header IfNoneMatch

This PR will fix localstack/issues/5345

@codecov-commenter
Copy link

Codecov Report

Merging #5715 (ee228e9) into master (2253958) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5715      +/-   ##
==========================================
- Coverage   96.20%   96.19%   -0.01%     
==========================================
  Files         743      748       +5     
  Lines       72990    73222     +232     
==========================================
+ Hits        70219    70437     +218     
- Misses       2771     2785      +14     
Flag Coverage Δ
servertests 36.80% <100.00%> (-0.05%) ⬇️
unittests 96.13% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
moto/s3/responses.py 95.66% <100.00%> (ø)
moto/iam/models.py 95.76% <0.00%> (-0.13%) ⬇️
moto/acmpca/exceptions.py 100.00% <0.00%> (ø)
moto/acmpca/models.py 95.48% <0.00%> (ø)
moto/acmpca/responses.py 93.25% <0.00%> (ø)
moto/acmpca/urls.py 100.00% <0.00%> (ø)
moto/acmpca/__init__.py 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @macnev2013

@bblommers bblommers added this to the 4.0.11 milestone Nov 29, 2022
@bblommers bblommers merged commit 3d16834 into getmoto:master Nov 29, 2022
@github-actions
Copy link
Contributor

This is now part of moto >= 4.0.11.dev21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Using double quotes around etag in If-None-Match changes content-type in response
3 participants