Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greengrass Implement subscription_definition APIs #5240

Merged

Conversation

cm-iwata
Copy link
Contributor

Implement these APIs

  • create_subscription_definition
  • list_subscription_definitions
  • get_subscription_definition
  • delete_subscription_definition
  • update_subscription_definition
  • create_subscription_definition_version
  • list_subscription_definition_versions
  • get_subscription_definition_version

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #5240 (7f543ce) into master (a44a9df) will increase coverage by 0.00%.
The diff coverage is 98.72%.

@@           Coverage Diff            @@
##           master    #5240    +/-   ##
========================================
  Coverage   95.86%   95.87%            
========================================
  Files         688      688            
  Lines       68269    68426   +157     
========================================
+ Hits        65448    65603   +155     
- Misses       2821     2823     +2     
Flag Coverage Δ
servertests 36.32% <12.10%> (-0.06%) ⬇️
unittests 95.81% <98.72%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
moto/greengrass/urls.py 100.00% <ø> (ø)
moto/greengrass/models.py 99.02% <97.93%> (-0.34%) ⬇️
moto/greengrass/responses.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a44a9df...7f543ce. Read the comment docs.

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @cm-iwata

@bblommers bblommers merged commit 62923af into getmoto:master Jun 17, 2022
@bblommers bblommers added this to the 3.1.14 milestone Jun 17, 2022
@github-actions
Copy link
Contributor

This is now part of moto >= 3.1.14.dev16

sahilshah6196 pushed a commit to EBSCOIS/moto that referenced this pull request Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants