Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greengrass Implement resource_definition_version APIs #5237

Conversation

cm-iwata
Copy link
Contributor

Implement these APIs

  • list_resource_definition_versions
  • get_resource_definition_version

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - happy to merge if you resolve the conflicts

@cm-iwata cm-iwata force-pushed the feature/greengrass-resource-definition-version branch from d4ee343 to 42dc58c Compare June 17, 2022 00:21
@cm-iwata
Copy link
Contributor Author

@bblommers
I fixed conflicts.
Please review again.

@codecov-commenter
Copy link

codecov-commenter commented Jun 17, 2022

Codecov Report

Merging #5237 (42dc58c) into master (6a1a8ee) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5237   +/-   ##
=======================================
  Coverage   95.86%   95.86%           
=======================================
  Files         688      688           
  Lines       68240    68265   +25     
=======================================
+ Hits        65419    65444   +25     
  Misses       2821     2821           
Flag Coverage Δ
servertests 36.38% <8.00%> (-0.02%) ⬇️
unittests 95.80% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
moto/greengrass/urls.py 100.00% <ø> (ø)
moto/greengrass/models.py 99.36% <100.00%> (+0.02%) ⬆️
moto/greengrass/responses.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a1a8ee...42dc58c. Read the comment docs.

@bblommers bblommers merged commit 19bb5f9 into getmoto:master Jun 17, 2022
@bblommers bblommers added this to the 3.1.14 milestone Jun 17, 2022
@github-actions
Copy link
Contributor

This is now part of moto >= 3.1.14.dev14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants