Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greengrass Implement resource_definition APIs #5235

Merged

Conversation

cm-iwata
Copy link
Contributor

Implement these APIs

  • list_resource_definitions
  • get_resource_definition
  • delete_resource_definition
  • update_resource_definition

@codecov-commenter
Copy link

codecov-commenter commented Jun 16, 2022

Codecov Report

Merging #5235 (c3495bc) into master (c3f0606) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #5235   +/-   ##
=======================================
  Coverage   95.85%   95.85%           
=======================================
  Files         688      688           
  Lines       68060    68107   +47     
=======================================
+ Hits        65239    65286   +47     
  Misses       2821     2821           
Flag Coverage Δ
servertests 36.44% <12.76%> (-0.02%) ⬇️
unittests 95.79% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
moto/greengrass/urls.py 100.00% <ø> (ø)
moto/greengrass/exceptions.py 100.00% <100.00%> (ø)
moto/greengrass/models.py 99.13% <100.00%> (+0.06%) ⬆️
moto/greengrass/responses.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3f0606...c3495bc. Read the comment docs.

@cm-iwata cm-iwata changed the title Greengrass Implement resource_definition_version APIs Greengrass Implement resource_definition APIs Jun 16, 2022
Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bblommers bblommers merged commit 6272d58 into getmoto:master Jun 16, 2022
@bblommers bblommers added this to the 3.1.14 milestone Jun 16, 2022
@github-actions
Copy link
Contributor

This is now part of moto >= 3.1.14.dev12

sahilshah6196 pushed a commit to EBSCOIS/moto that referenced this pull request Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants