Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: handle overlapping routes (#5187) #5233

Merged
merged 1 commit into from Jun 15, 2022

Conversation

mmerrill3
Copy link
Contributor

Implemenation for handling non local routes that already exist for #5187
Signed-off-by: mmerrill3 jjpaacks@gmail.com

Signed-off-by: mmerrill3 <jjpaacks@gmail.com>
@codecov-commenter
Copy link

codecov-commenter commented Jun 15, 2022

Codecov Report

Merging #5233 (a9d24d2) into master (1bbdbc2) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5233      +/-   ##
==========================================
- Coverage   95.85%   95.84%   -0.01%     
==========================================
  Files         688      688              
  Lines       67977    68061      +84     
==========================================
+ Hits        65156    65232      +76     
- Misses       2821     2829       +8     
Flag Coverage Δ
servertests 36.46% <52.94%> (-0.03%) ⬇️
unittests 95.78% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
moto/ec2/exceptions.py 97.61% <100.00%> (+0.02%) ⬆️
moto/ec2/models/route_tables.py 95.58% <100.00%> (+0.16%) ⬆️
moto/resourcegroupstaggingapi/models.py 82.93% <0.00%> (-0.60%) ⬇️
moto/sns/models.py 96.81% <0.00%> (-0.40%) ⬇️
moto/route53/responses.py 86.91% <0.00%> (-0.34%) ⬇️
moto/sqs/models.py 96.73% <0.00%> (-0.18%) ⬇️
moto/config/models.py 99.21% <0.00%> (-0.14%) ⬇️
moto/ssm/models.py 94.50% <0.00%> (-0.11%) ⬇️
moto/greengrass/responses.py 100.00% <0.00%> (ø)
moto/greengrass/models.py 99.06% <0.00%> (+0.31%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bbdbc2...a9d24d2. Read the comment docs.

@mmerrill3
Copy link
Contributor Author

@bblommers ready for review

Copy link
Collaborator

@bblommers bblommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one - thanks @mmerrill3!

@bblommers bblommers merged commit c3f0606 into getmoto:master Jun 15, 2022
@bblommers bblommers added this to the 3.1.14 milestone Jun 15, 2022
@github-actions
Copy link
Contributor

This is now part of moto >= 3.1.14.dev11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

moto not throw ClientError that difference with boto3 when create_route with existing route
3 participants