Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Hazelcast client-server topology integration tests #1527

Closed
vpavic opened this issue Oct 6, 2019 · 2 comments
Closed

Improve Hazelcast client-server topology integration tests #1527

vpavic opened this issue Oct 6, 2019 · 2 comments
Assignees
@vpavic
Labels
status: backported An issue that has been backported to maintenance branches type: task A general task
Milestone
2.2.0

Comments

@vpavic
Copy link
Contributor

vpavic commented Oct 6, 2019

Instead of providing Hazelcast server config via system properties in our client-server topology integration tests, we could simplify things by copying config file to default location thus overriding the default one provided in the container.

This will also help us with adopting to changes from testcontainers/testcontainers-java#1814, that are preventing us to upgrade to Testcontainers 3.12.1+.
@vpavic vpavic added the type: task A general task label Oct 6, 2019
@vpavic vpavic added this to the 2.2.0 milestone Oct 6, 2019
@vpavic vpavic self-assigned this Oct 6, 2019
@vpavic vpavic closed this as completed in 30588dc Oct 6, 2019
@vpavic vpavic mentioned this issue Oct 6, 2019
Closed
@bsideup
Copy link

bsideup commented Oct 6, 2019

@vpavic wait... did testcontainers/testcontainers-java#1814 break your code? o_O

It was supposed to be a backward-compatible change and, if it did, it sounds like a regression! 😨

@vpavic
Copy link
Contributor Author

vpavic commented Oct 6, 2019

Yep, I've just left a comment there.

@bsideup bsideup mentioned this issue Oct 6, 2019
Closed
@vpavic vpavic added the for: backport-to-2.1.x Designates an issue for backport to 2.1.x label Oct 7, 2019
@spring-projects-issues spring-projects-issues added status: backported An issue that has been backported to maintenance branches and removed for: backport-to-2.1.x Designates an issue for backport to 2.1.x labels Oct 7, 2019
Closed
vpavic added a commit that referenced this issue Oct 7, 2019
@vpavic
Improve Hazelcast client-server topology integration tests
4a3f0d5 
Resolves: #1527
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vpavic vpavic

Labels
status: backported An issue that has been backported to maintenance branches type: task A general task
Projects
None yet
Milestone
2.2.0
Development

No branches or pull requests
3 participants
@bsideup @vpavic @spring-projects-issues