Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sign SP Metadata #14801

Open
siddharth-78 opened this issue Mar 25, 2024 · 1 comment · May be fixed by #14916
Open

Sign SP Metadata #14801

siddharth-78 opened this issue Mar 25, 2024 · 1 comment · May be fixed by #14916
Assignees
@jzheaux
Labels
in: saml2 An issue in SAML2 modules status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement

Comments

@siddharth-78
Copy link

The EOL SAML version provided a way to sign SP metadata like this:

 ExtendedMetadata extendedMetadata = generator.generateExtendedMetadata();
    if (!StringUtils.isEmpty(entityAlias)) {
      extendedMetadata.setAlias(entityAlias);
    }
    extendedMetadata.setSignMetadata(true);

I don't find anything of this fashion with the newer saml version (saml2-service-provider 5.8.9), has the support for signing SP metadata dropped? Or am I missing something?
@siddharth-78 siddharth-78 added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Mar 25, 2024
@jzheaux jzheaux self-assigned this Apr 2, 2024
@jzheaux jzheaux added in: saml2 An issue in SAML2 modules and removed status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Apr 2, 2024
@jzheaux
Copy link
Contributor

jzheaux commented Apr 5, 2024

Hi, @siddharth-78, no this has not been added yet. Are you able to contribute a PR to add setSignMetadata(boolean) to OpenSamlMetadataResolver? It may be as straightforward as copying OpenSamlSigningUtils and Saml2Utils into the corresponding package and then calling OpenSamlSigningUtils#sign before serializing the value.

@jzheaux jzheaux added status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement labels Apr 5, 2024
CrazyParanoid pushed a commit to CrazyParanoid/spring-security that referenced this issue Apr 17, 2024
Add support sign SAML metadata
8e50e3c 
Closes spring-projectsgh-14801
@CrazyParanoid CrazyParanoid linked a pull request Apr 17, 2024 that will close this issue
Open
CrazyParanoid pushed a commit to CrazyParanoid/spring-security that referenced this issue Apr 18, 2024
Add support sign SAML metadata
a69f0e9 
Closes spring-projectsgh-14801
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jzheaux jzheaux

Labels
in: saml2 An issue in SAML2 modules status: ideal-for-contribution An issue that we actively are looking for someone to help us with type: enhancement A general enhancement
Projects
Spring Security Team
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support signing SAML metadata CrazyParanoid/spring-security
2 participants
@jzheaux @siddharth-78