Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security observations are not setting their parent osbervation #12524

Closed
bclozel opened this issue Jan 11, 2023 · 0 comments
Closed

Security observations are not setting their parent osbervation #12524

bclozel opened this issue Jan 11, 2023 · 0 comments
Assignees
Labels
in: core An issue in spring-security-core type: bug A general bug
Milestone

Comments

@bclozel
Copy link
Member

bclozel commented Jan 11, 2023

Original issue: spring-projects/spring-boot#33495

Spring Boot auto-configures the reactive ServerHttpObservationFilter ahead of the Spring Security WebFilter; the former creates an Observation for the entire handling of the web request. It looks like Spring Securityis starting an observation in ObservationReactiveAuthorizationManager, without looking into the reactive context if there is an existing one. In this case, the web observation should be set as the parent of the security one in order to have the expected resulting trace.

A contributor has tested these changes and reported that this is fixing the problem.

@bclozel bclozel added status: waiting-for-triage An issue we've not yet triaged type: bug A general bug labels Jan 11, 2023
@jzheaux jzheaux self-assigned this Jan 11, 2023
@jzheaux jzheaux added in: web An issue in web modules (web, webmvc) in: core An issue in spring-security-core and removed status: waiting-for-triage An issue we've not yet triaged in: web An issue in web modules (web, webmvc) labels Jan 11, 2023
@jzheaux jzheaux added this to the 6.0.2 milestone Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in: core An issue in spring-security-core type: bug A general bug
Projects
None yet
Development

No branches or pull requests

2 participants