Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SecurityContextRepository.loadContext(HttpServletRequest) cache result #11390

Closed
rwinch opened this issue Jun 17, 2022 · 1 comment
Closed

SecurityContextRepository.loadContext(HttpServletRequest) cache result #11390

rwinch opened this issue Jun 17, 2022 · 1 comment
Assignees
@rwinch
Labels
in: web An issue in web modules (web, webmvc) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Milestone
5.7.2

Comments

@rwinch
Copy link
Member

rwinch commented Jun 17, 2022

If the Supplier<SecurityContext> returned from SecurityContextRepository.loadContext(HttpServletRequest) is invoked multiple times it should only invoke loadContext(HttpRequestResponseHolder) once.
@rwinch rwinch added in: web An issue in web modules (web, webmvc) type: bug A general bug labels Jun 17, 2022
@rwinch rwinch added this to the 5.7.2 milestone Jun 17, 2022
@rwinch rwinch self-assigned this Jun 17, 2022
rwinch added a commit that referenced this issue Jun 17, 2022
@rwinch
Cache SecurityContextRepository.loadContext(HttpServletRequest) Result
29db051 
Closes gh-11390
@github-actions
Copy link
Contributor

Fixed via 29db051

rwinch added a commit that referenced this issue Jun 17, 2022
@rwinch
Cache SecurityContextRepository.loadContext(HttpServletRequest) Result
591d1ed 
Closes gh-11390
@github-actions github-actions bot added the status: backported An issue that has been backported to maintenance branches label Jun 17, 2022
@github-actions github-actions bot mentioned this issue Jun 17, 2022
Closed
rwinch added a commit that referenced this issue Jun 17, 2022
@rwinch
Cache SecurityContextRepository.loadContext(HttpServletRequest) Result
d4a03dc 
Closes gh-11390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rwinch rwinch

Labels
in: web An issue in web modules (web, webmvc) status: backported An issue that has been backported to maintenance branches type: bug A general bug
Projects
None yet
Milestone
5.7.2
Development

No branches or pull requests
1 participant
@rwinch