Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The oauth2login samples should show OIDC logout configuration #3

Open
jzheaux opened this issue Aug 21, 2019 · 7 comments
Open

The oauth2login samples should show OIDC logout configuration #3

jzheaux opened this issue Aug 21, 2019 · 7 comments
Assignees

Comments

@jzheaux
Copy link
Contributor

jzheaux commented Aug 21, 2019

Related to spring-projects/spring-security#7285 (comment)

@jzheaux jzheaux self-assigned this Aug 21, 2019
@jzheaux jzheaux removed their assignment Apr 14, 2020
@ThomasVitale
Copy link

@jzheaux can I help with this task?

@jzheaux
Copy link
Contributor Author

jzheaux commented Nov 11, 2020

Yes, @ThomasVitale, that would be most welcome. We're moving our samples over to https://github.com/spring-projects/spring-security-samples, so I'm going to transfer this issue over there.

I think it would be helpful to have a new sample that's focused on OIDC, including logout. The existing oauth2Login samples are a showcase of common providers, but not all of them support OIDC. Publishing the OidcClientInitiatedLogoutSuccessHandler in those samples could be confusing.

Would you be able to create a new sample?

@jzheaux jzheaux transferred this issue from spring-projects/spring-security Nov 11, 2020
@ThomasVitale
Copy link

@jzheaux Yes, I can do that. Should I use only one OIDC provider in the sample? For example, would Keycloak be ok? Any recommendation for the name of the project (that I guess should go in spring-security-samples/servlet/spring-boot/java/oauth2).

@jzheaux
Copy link
Contributor Author

jzheaux commented Nov 12, 2020

Yep, I think that one provider would be fine. For now, it might be best to leave placeholders for the properties, similar to how the oauth2Login samples do it. Since Okta offers free dev accounts and they support OIDC, you could borrow the other samples' Okta instructions for the README.

For a name, I'd do oidc/login, as in spring-security-samples/servlet/spring-boot/java/oidc/login.

@ThomasVitale
Copy link

Perfect, thank you. I'll do that.

@marcusdacoregio
Copy link
Contributor

@ThomasVitale have you had a chance to look into this?

@erycoking
Copy link

Hi guys, am facing an issue with the spring oauth2 authorization server. Once the user signs in for the first time using the authorization code flow, the next time they try to log in they are automatically logged in without filling in the username and password, which is not the desired behavior for me. Is there a way to log them out completely so that they will have to fill in the form again to log in?? please any help would go a long way? I am stuck, I have also posted this question on stack overflow, you can follow this link https://stackoverflow.com/questions/70735327/spring-oauth2-authorization-server-unable-to-logout-users

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants