New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add test for next generation consumer-group rebalance protocol #3145
Comments
I am investigating whether I can resolve this issue on my own. However, it seems currently unachievable due to the limitations of I have created an issue with the |
Thank you for looking into this! Would you mind to share more info what the problem have you faced? It is a bit odd to hear that broker behavior has some how an effect on the consumer:
|
@chickenchickenlove This is an issue we need to tackle before the GA release, so we were planning to take a look at this, glad that you started on it. Please let us know if disabling |
@sobychacko, @artembilan thanks for you guys comments. This is issue which i reported. However, i have problem when i used KafkaTestKit with NOTE: We cannot set I may not be very knowledgeable about The Do you have any idea how |
Thanks for sharing! So, if we cannot change I wonder if we need to think about changing a default |
I think staying with |
@artembilan, @sobychacko. I have created two versions of the After setting up the consumer configurations identically, the consumer sent requests to each broker( In Thus, i think we should you If we should test it anyway, i have one workaround.
I think it can be one of work around. But of course, we must endure the longer test times and the addition of new dependencies. What do you think, you guys? |
@chickenchickenlove Thanks for these findings. Is the fact that the new consumer protocol is not working with ZK a well-known issue? Is there a corresponding Kafka Jira issue that we can link from here? If this is the case, we should mention it in our docs until it is resolved; otherwise, we will see issues related to it coming to this project, thinking that the issue is in Spring for Apache Kafka. Regarding your question about using test containers, we discussed this as an alternative internally yesterday but opted against bringing it into the project. We don't really need a test for this feature in the framework; we thought that it would be nice to have a test to verify it since this is the first time we are exposing this via Spring for Apache Kafka. The framework didn't have to make any code changes related to this when we upgraded to the |
Or we can opt-in for respective sample where we can use Testcontaiers to demonstrate the feature... |
@artembilan That too. |
@sobychacko
No, it is my assumption based on test result, not a fact yet.
I agree 👍. @artembilan |
Sure! We prefer to have our tests as stable as possible, so we try to rely on random ports and log dirs to not interfere with other tests. Does it make sense now? |
Also, this feature is not ready for prime time just because it is available via the |
@artembilan Thanks for your kind explanation. @artembilan, @sobychacko
|
Answer “yes” for all your questions. Since it is a sample and it has to be an independent project everything is totally fine. We chose Maven because back in days it was a fact that Gradle users know Maven as well 😅 |
Hi, @sobychacko @artembilan ! I created a new issue on Apache JIRA to inquire whether the
@artembilan thanks your comments! I will create new PR!! thanks 👍 |
I got reply. you can check it in this issue (https://issues.apache.org/jira/browse/KAFKA-16657)
|
Starting with
3.7.0
, the Kafka client now supports a new consumer group rebalance protocol and categorizes the consumer-group strategy as legacy (classic) vs. consumer. Spring for Apache Kafka supports the new protocol transparently; however, we need to verify this by adding an integration test. See more details here.The text was updated successfully, but these errors were encountered: